Re: [PATCH 1/1] perf tools: fix format max value calculation

From: Arnaldo Carvalho de Melo
Date: Thu Mar 31 2016 - 10:49:56 EST


Em Wed, Mar 30, 2016 at 12:16:15PM -0700, kan.liang@xxxxxxxxx escreveu:
> From: Kan Liang <kan.liang@xxxxxxxxx>
>
> Currently the max value of format is calculated by the bits number. It
> relies on the continuity of the format.
> However, uncore event format is not continuous. E.g. uncore qpi event
> format can be 0-7,21.
> If bit 21 is set, there is parsing issues as below.
> perf stat -a -e uncore_qpi_0/event=0x200002,umask=0x8/
> event syntax error: '..pi_0/event=0x200002,umask=0x8/'
> \___ value too big for format, maximum
> is 511
>
> This patch return the real max value by setting all possible bit to 1.

Looks good, applied.

- Arnaldo