Re: [PATCH 1/2] asm-generic/io.h: provide default ioremap/iounmap for !HAS_IOMEM

From: Arnd Bergmann
Date: Wed Mar 30 2016 - 16:38:39 EST


On Wednesday 30 March 2016 22:35:37 Richard Weinberger wrote:
> Am 30.03.2016 um 22:08 schrieb Geert Uytterhoeven:
> >> I actually started a patch to remove the HAS_IOMEM dependency
> >> everywhere (or just the per driver cases). It didn't break as bad as I
> >> expected, but became more than I wanted to fix. Mainly, all the devm_
> >> variants also need empty versions or to be always enabled.
> >
> > Should these dependencies on HAS_IOMEM be changed to "HAS_IOMEM ||
> > COMPILE_TEST"?
>
> Another idea, the issue with COMPILE_TEST is that it is automatically selected
> by make targets such as allyesconfig or allmodconfig.
> Couldn't we make COMPILE_TEST just harder to select?
> i.e. that with allyesconfig it is still disabled and if someone really wants to
> do a compile test of anything we could issue something like "make allyesconfig COMPILE_TEST=y"
> to have COMPILE_TEST selected?
>

I think it's essential for allmodconfig and allyesconfig to enable
COMPILE_TEST: the only reason for ever building those configurations
is for compile tests.

Arnd