Re: [PATCH v4 3/4] Sysctl: SROP Mitigation: Add Sysctl argument to disable SROP.

From: Andi Kleen
Date: Tue Mar 29 2016 - 16:53:28 EST


On Tue, Mar 29, 2016 at 02:46:03PM -0600, Scotty Bauer wrote:
>
>
>
> On 03/29/2016 01:59 PM, Andi Kleen wrote:
> > On Tue, Mar 29, 2016 at 01:53:26PM -0600, Scott Bauer wrote:
> >> This patch adds a sysctl argument to disable SROP protection.
> >
> > Sysctl needs to be documented in Documentation/sysctl/
> >
> > Also negated sysctl is weird, normally they are positive (enable-xxx)
> >
>
> Sure, I can change it. This may be a dumb question: I want SROP to be enabled by default, and thus the new
> enable-xxx will be initialized to 1, that's fine, right?

Yes that's fine.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only