Re: [PATCH] scripts/gdb: Fix loading of modules information

[Jan Kiszka]

On 2016-03-29 08:41, Daniel Wagner wrote:
> From: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>
> 
> The module_core symbols is not available due to
> 
> 7523e4dc5057 ("module: use a structure to encapsulate layout.")
> 
> The base address of the module is now stored inside
> struct module_layout.
> 
> Signed-off-by: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx>
> Cc: Jiri Kosina <jkosina@xxxxxxx>
> Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> ---
>  scripts/gdb/linux/modules.py | 3 ++-
>  scripts/gdb/linux/symbols.py | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/gdb/linux/modules.py b/scripts/gdb/linux/modules.py
> index 25db8cf..cffe078 100644
> --- a/scripts/gdb/linux/modules.py
> +++ b/scripts/gdb/linux/modules.py
> @@ -74,7 +74,8 @@ class LxLsmod(gdb.Command):
>  
>          for module in module_list():
>              gdb.write("{address} {name:<19} {size:>8}  {ref}".format(
> -                address=str(module['module_core']).split()[0],
> +                module_layout=module['core_layout']
> +                addressr=str(module_layout['base'])

This looks untested.

>                  name=module['name'].string(),
>                  size=str(module['core_size']),
>                  ref=str(module['refcnt']['counter'])))
> diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
> index 627750c..8650ede 100644
> --- a/scripts/gdb/linux/symbols.py
> +++ b/scripts/gdb/linux/symbols.py
> @@ -108,7 +108,8 @@ lx-symbols command."""
>  
>      def load_module_symbols(self, module):
>          module_name = module['name'].string()
> -        module_addr = str(module['module_core']).split()[0]
> +        module_layout = module['core_layout']
> +        module_addr = str(module_layout['base'])
>  
>          module_file = self._get_module_file(module_name)
>          if not module_file and not self.module_files_updated:
> 

Thanks, but ad4db3b24a should already be on its way into stable.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux