Re: [PATCH 09/17] watchdog: qcom: add kpss-standalone to device tree binding

From: Matthew McClintock
Date: Mon Mar 28 2016 - 18:22:41 EST


On Mar 28, 2016, at 1:15 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
>>> What SoC(s) is this in. Use SoC specific compatible strings please.
>>
>> So ipq4019 wins the race because we are the first to try to enable watchdog for this block?
>>
>> qcom,kpss-ipq4019 ?
>>
> It is a dedicated watchdog block, isn't it ? "qcom,kpss-ipq4019" would not
> refer to a specific block. Devicetree maintainers may have a better idea,
> but it seems to me that there should be 'wdt' or 'watchdog' in the property
> name.

Sounds fine to me, if no one has any other comments Iâll use this one in the next spin of the patch.

-M