Re: [PATCH] Syntactic and factual errors in the API document

From: Eduardo Valentin
Date: Mon Mar 28 2016 - 09:41:25 EST


On Tue, Mar 22, 2016 at 09:00:32AM -0700, Eduardo Valentin wrote:
> Hello Andy,
>
> On Tue, Mar 22, 2016 at 12:37:25PM +0000, Andy Champ wrote:
> > There are several places where the English in the document is syntactically
> > invalid, or unclear. There are also one or two factual errors.

BTW, you are supposed to sign your patches too. I am adding your
signed-off-by here, but next time, remember to sign your patches (have a
look at the Documentation/SubmittingPatches file.

> >
> > ---
> > Documentation/thermal/sysfs-api.txt | 44 ++++++++++++++++++-------------------
> > 1 file changed, 22 insertions(+), 22 deletions(-)
>
> Thanks for your patch improving the documentation. I have no comments in
> the text correction. The only minor is that the patch title should have
> 'thermal:' prefix (have a look in the git log
> Documentation/thermal/sysfs-api.txt).
>
> Also, I will get this patch only after the merge window is finished and
> my current pending patches queue has been sent and merged.
>
> BR,
>
> Eduardo Valentin