Re: [PATCH 00/23] Nokia N950 display support

From: Emil Velikov
Date: Mon Mar 28 2016 - 08:35:03 EST


Hi Sebastian,

On 9 March 2016 at 17:09, Sebastian Reichel <sre@xxxxxxxxxx> wrote:
> Hi Emil,
>
> On Wed, Mar 09, 2016 at 04:19:48PM +0000, Emil Velikov wrote:
>> Hi Sebastian,
>>
>> On 8 March 2016 at 16:39, Sebastian Reichel <sre@xxxxxxxxxx> wrote:
>>
>> > arch/arm/boot/dts/omap3-n950-n9.dtsi | 72 +++++++++
>> > arch/arm/boot/dts/omap3-n950.dts | 71 +++++++++
>> Just a friendly reminder that updating these and one will have to keep
>> the driver backwards compatible forever.
>
> Of course. Basically the new DT properties are:
>
> * optional regulators (vpnl & vddi)
> * boolean "has-dsi-backlight"
> * resolution-x/y
> * offset-x/y
>
> So probably not that much of a problem even if other API is
> invented. I just noticed, that I forgot to actually add documentation
> in Documentation/devicetree/bindings/display/panel/panel-dsi-cm.txt
>
> I will fix that in the next patchset revision.
>
>> Tomi, has been in the process of removing all the unneeded cruft,
>> although omapdrm it is still using the custom panel, dsi and other
>> code as opposed to the ones provided by DRM. As he gets to reusing
>> those he might have some fun keeping things compatible.
>
> I could not find "generic" panel binding documentation. Can you
> give me a pointer? I can just stick to the same property names
> to avoid potential future problems.
>
Pardon for the late reply.

As mentioned in another email, if you're interested in reusing the drm
panel infrastructure you should be looking in
Documentation/devicetree/bindings/display/panel/. With display-timing
panel-dpi panel-dsi-cm and (optional) simple-panel as a start.

Would reshuffling/documenting things make it more obvious ? Feel free
to let Rob Herring, Thierry Reding know.

Regards,
Emil