Re: [PATCH 3/3] drivers/cpufreq: make ppc_cbe_cpufreq_pmi driver explicitly non-modular

From: Viresh Kumar
Date: Sun Mar 27 2016 - 22:33:24 EST


On 27-03-16, 18:08, Paul Gortmaker wrote:
> The Kconfig for this driver is currently:
>
> config CPU_FREQ_CBE_PMI
> bool "CBE frequency scaling using PMI interface"
>
> ...meaning that it currently is not being built as a module by
> anyone. Lets remove the modular and unused code here, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>
> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Cc: Christian Krafft <krafft@xxxxxxxxxx>
> Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> Cc: linuxppc-dev@xxxxxxxxxxxxxxxx
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> ---
> drivers/cpufreq/ppc_cbe_cpufreq_pmi.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh