Re: [PATCH] vlan: propagate gso_min_segs

From: Eric Dumazet
Date: Wed Mar 23 2016 - 14:34:33 EST


On Wed, 2016-03-23 at 14:25 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> Date: Tue, 22 Mar 2016 19:33:52 -0700
>
> > On Wed, 2016-03-23 at 09:35 +0800, Haishuang Yan wrote:
> >> vlan drivers lack proper propagation of gso_min_segs from lower device.
> >>
> >> Signed-off-by: Haishuang Yan <yanhaishuang@xxxxxxxxxxxxxxxxxxxx>
> >> ---
> >
> > The plan was to get rid of gso_min_segs, as nothing uses it.
> >
> > Otherwise I would have included this in my recent patches...
> >
> > For such a rare 'issue' , we believe ndo_features_check() is better,
> > because it does not slow down the fast path.
>
> I'm not aplpying this.

I am adding to my TODO list a revert, when net-next opens again.

Thanks.