Re: [PATCH] dlm: config: Fix ENOMEM failures in make_cluster()

From: Christoph Hellwig
Date: Tue Mar 22 2016 - 14:24:54 EST


On Tue, Mar 22, 2016 at 05:36:34PM +0000, Andrew Price wrote:
> Commit 1ae1602de0 "configfs: switch ->default groups to a linked list"
> left the NULL gps pointer behind after removing the kcalloc() call which
> made it non-NULL. It also left the !gps check in place so make_cluster()
> now fails with ENOMEM. Remove the remaining uses of the gps variable to
> fix that.
>
> Reviewed-by: Bob Peterson <rpeterso@xxxxxxxxxx>
> Reviewed-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
> Signed-off-by: Andrew Price <anprice@xxxxxxxxxx>

Oops, sorry. Thanks for fixing this up!