Re: [PATCH 6/6] drivers/media/dvb-usb-dvb: postpone kfree(mdev)

From: kbuild test robot
Date: Mon Mar 21 2016 - 09:57:56 EST


Hi Max,

[auto build test WARNING on v4.5-rc7]
[cannot apply to sailus-media/master linuxtv-media/master next-20160321]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url: https://github.com/0day-ci/linux/commits/Max-Kellermann/drivers-media-dvb-core-en50221-move-code-to-dvb_ca_private_free/20160321-213556
config: xtensa-allyesconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa

All warnings (new ones prefixed by >>):

drivers/media/usb/dvb-usb/dvb-usb-dvb.c: In function 'dvb_usb_media_device_unregister':
>> drivers/media/usb/dvb-usb/dvb-usb-dvb.c:148:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
struct media_device *mdev = adap->dvb_adap.mdev;
^

vim +148 drivers/media/usb/dvb-usb/dvb-usb-dvb.c

132
133 static int dvb_usb_media_device_register(struct dvb_usb_adapter *adap)
134 {
135 #ifdef CONFIG_MEDIA_CONTROLLER_DVB
136 return media_device_register(adap->dvb_adap.mdev);
137 #else
138 return 0;
139 #endif
140 }
141
142 static void dvb_usb_media_device_unregister(struct dvb_usb_adapter *adap)
143 {
144 #ifdef CONFIG_MEDIA_CONTROLLER_DVB
145 if (!adap->dvb_adap.mdev)
146 return;
147
> 148 struct media_device *mdev = adap->dvb_adap.mdev;
149 adap->dvb_adap.mdev = NULL;
150 media_device_unregister(mdev);
151 /* media_device_cleanup() and kfree() will be called by the
152 callback function dvb_usb_media_device_release() */
153 #endif
154 }
155
156 int dvb_usb_adapter_dvb_init(struct dvb_usb_adapter *adap, short *adapter_nums)

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data