Re: [PATCH v3] rtc: s3c: Don't print an error on probe deferral

From: Alexandre Belloni
Date: Fri Mar 18 2016 - 19:08:32 EST


On 14/03/2016 at 22:38:38 -0300, Javier Martinez Canillas wrote :
> The clock and source clock looked up by the driver may not be available
> just because the clock controller driver was not probed yet so printing
> an error in this case is not correct and only adds confusion to users.
>
> However, knowing that a driver's probe was deferred may be useful so it
> can be printed as a debug information.
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>
> ---
>
> Changes in v3:
> - Change debug messages again as suggested by Joe Perches.
>
> Changes in v2:
> - Improve debug messages as suggested by Joe Perches.
>
> drivers/rtc/rtc-s3c.c | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
Applied, thanks.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com