Re: [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular
From: Peter Zijlstra
Date: Fri Mar 18 2016 - 04:34:14 EST
On Thu, Mar 17, 2016 at 05:34:14AM -0700, kan.liang@xxxxxxxxx wrote:
> +static void __exit intel_uncore_exit(void)
> +{
> + cpu_notifier_register_done();
Did you even test this? That should be _begin();
> + __unregister_cpu_notifier(&uncore_cpu_nb);
> + uncore_types_exit(uncore_msr_uncores);
> + uncore_pci_exit();
> + cpu_notifier_register_done();
> +}
> +module_exit(intel_uncore_exit);
> --
> 2.5.0
>