Re: [PATCH 00/04] iommu/ipmmu-vmsa: IPMMU CONFIG_IOMMU_DMA update

From: Laurent Pinchart
Date: Thu Mar 17 2016 - 12:46:38 EST


Hi Magnus,

Thank you for the patches.

On Wednesday 16 March 2016 02:04:31 Magnus Damm wrote:
> iommu/ipmmu-vmsa: IPMMU CONFIG_IOMMU_DMA update
>
> [PATCH 01/04] iommu/ipmmu-vmsa: 32-bit ARM may have CONFIG_IOMMU_DMA=y
> [PATCH 02/04] iommu/ipmmu-vmsa: Break out utlb parsing code
> [PATCH 03/04] iommu/ipmmu-vmsa: Break out domain allocation code
> [PATCH 04/04] iommu/ipmmu-vmsa: Add new IOMMU_DOMAIN_DMA ops
>
> This series updates the IPMMU driver with CONFIG_IOMMU_DMA=y support
> which is present in mainline for 64-bit ARM while experimental support
> has been posted for 32-bit ARM thanks to Marek Szyprowski:
>
> [RFC 0/3] Unify IOMMU-based DMA-mapping code for ARM and ARM64
>
> Most of the patches in this series based on code earlier included in
> the series below but has been reworked to also fit on 32-bit ARM:
>
> [PATCH/RFC 00/10] iommu/ipmmu-vmsa: Experimental r8a7795 support
>
> Signed-off-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>

Great ! Thanks a lot for the work, I'm really happy to see this being
addressed.

For patches 1/4 to 3/4,

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

For patch 4/4, please see my comments in the reply to the patch.

> ---
>
> Built on top of next-20160315
> Depends on [PATCH v2 00/04] iommu/ipmmu-vmsa: IPMMU multi-arch update V2
>
> drivers/iommu/ipmmu-vmsa.c | 238 ++++++++++++++++++++++++++++++----------
> 1 file changed, 174 insertions(+), 64 deletions(-)

--
Regards,

Laurent Pinchart