Re: [PATCH 2/5] ARM: davinci: da8xx: add usb phy clocks

[David Lechner]

On 03/16/2016 07:27 AM, Sergei Shtylyov wrote:
> > +static struct clk usb20_clk = {
> > +    .name        = "usb20",
> > +    .parent        = &pll0_sysclk2,
> > +    .lpsc        = DA8XX_LPSC1_USB20,
> > +    .gpsc        = 1,
> > +};
>
>     Why move it?

For organization, to keep all of the USB clocks together. I can leave it 
alone if that is preferred.

> > +
> > +    /* Set the mux depending on the parent clock. */
> > +    if (clk->parent == &pll0_aux_clk)
> > +        val |= CFGCHIP2_USB2PHYCLKMUX;
> > +    else if (clk->parent == &usb_ref_clk)
> > +        val &= ~CFGCHIP2_USB2PHYCLKMUX;
>
>     Don't we have clk_set_parent()for that?

Yes. clk_set_parent() is already called in a loop for all clocks 
elsewhere, so not needed here.

---

Thank you for the careful review. I will address the other problems you 
pointed out.