Re: linux-next: build failure after merge of the aio tree

From: Benjamin LaHaise
Date: Wed Mar 16 2016 - 10:07:21 EST


On Wed, Mar 16, 2016 at 02:59:38PM +0100, Arnd Bergmann wrote:
> On Wednesday 16 March 2016 13:12:36 Andy Shevchenko wrote:
> >
> > > I've also sent a patch that fixes the link error on ARM and that should
> > > work on all other architectures too.
> >
> > In case of avr32 signalfd_read() fails. Does your patch help with it as well?
> >
> > P.S. Bisecting shows same culprit: 150a0b4905f1 ("aio: add support for
> > async openat()")
>
> I don't know. What is the symptom on avr32? My patch only removes the
> get_user() instances on 64-bit values and replaces them with a
> single copy_from_user() call.

Which is the wrong fix. Arch code should be able to handle 64 bit values
in all the get/put_user() variants. We use 64 bit variables all over the
place in interfaces to userspace.

-ben