RE: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings

From: Yang, Wenyou
Date: Mon Mar 07 2016 - 20:56:49 EST


Hi Fengguang Wu,

Thank you for your patch.

> -----Original Message-----
> From: kbuild test robot [mailto:lkp@xxxxxxxxx]
> Sent: 2016年3月8日 7:54
> To: Yang, Wenyou <Wenyou.Yang@xxxxxxxxx>
> Cc: kbuild-all@xxxxxx; Lee Jones <lee.jones@xxxxxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>; Pawel Moll <pawel.moll@xxxxxxx>; Mark Rutland
> <mark.rutland@xxxxxxx>; Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>; Kumar
> Gala <galak@xxxxxxxxxxxxxx>; Ferre, Nicolas <Nicolas.FERRE@xxxxxxxxx>;
> linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Yang, Wenyou
> <Wenyou.Yang@xxxxxxxxx>
> Subject: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings
>
> drivers/mfd/act8945a.c:100:6-11: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> CC: Wenyou Yang <wenyou.yang@xxxxxxxxx>
> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>

Reviewed-by: Wenyou Yang <wenyou.yang@xxxxxxxxx>

> ---
>
> act8945a.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/mfd/act8945a.c
> +++ b/drivers/mfd/act8945a.c
> @@ -97,7 +97,6 @@ MODULE_DEVICE_TABLE(of, act8945a_of_matc static
> struct i2c_driver act8945a_i2c_driver = {
> .driver = {
> .name = "act8945a",
> - .owner = THIS_MODULE,
> .of_match_table = of_match_ptr(act8945a_of_match),
> },
> .probe = act8945a_i2c_probe,


Best Regards,
Wenyou Yang