Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)

From: David Miller
Date: Mon Mar 07 2016 - 14:07:07 EST


From: Dave Hansen <dave.hansen@xxxxxxxxx>
Date: Mon, 7 Mar 2016 09:35:57 -0800

> On 03/02/2016 12:39 PM, Khalid Aziz wrote:
>> +long enable_sparc_adi(unsigned long addr, unsigned long len)
>> +{
>> + unsigned long end, pagemask;
>> + int error;
>> + struct vm_area_struct *vma, *vma2;
>> + struct mm_struct *mm;
>> +
>> + if (!ADI_CAPABLE())
>> + return -EINVAL;
> ...
>
> This whole thing with the VMA splitting and so forth looks pretty darn
> arch-independent. Are you sure you need that much arch-specific code
> for it, or can you share more of the generic VMA management code?

This is exactly what I have suggested to him, and he has agreed to pursue.