Re: Applied "regulator: max8973: add support for junction thermal warning" to the regulator tree

[Laxman Dewangan]

On Monday 07 March 2016 01:14 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Mon, Mar 07, 2016 at 12:06:46PM +0530, Laxman Dewangan wrote:
>
> > Following will not help
> >              depends on THERMAL_OF if THERMAL_OF
> > because THERMAL_OF is always "y" even if THERMAL is "m".
> > Build error can by resolved by adding below in the Kconfig
> >      depends on THERMAL
> > but the issue is if THERMAL is "m" and  REGULATOR_MAX8973 is "y" as per the
> So that should be depends on THERMAL if THERMAL_OF

depends on THERMAL &&  THERMAL_OF

> > failure rand config then REGULATOR_MAX8973 automatically become "m". This
> > may break some existing platform.
> That's an inevitable consequence of adding this support, you can't get
> around it.

Did some more investigation on linux-next about the regression if we 
make this depends on THERMAL.

 MAX8973 enabled in  following defconfig
    arch/arm64/configs/defconfig:CONFIG_REGULATOR_MAX8973=y
        This has CONFIG_THERMAL=y
    arch/arm/configs/shmobile_defconfig:CONFIG_REGULATOR_MAX8973=y
        This has THERMAL_CONFIG=y
    arch/arm/configs/multi_v7_defconfig:CONFIG_REGULATOR_MAX8973=y
        This has THERMAL_CONFIG=y
    arch/arm/configs/pxa_defconfig:CONFIG_REGULATOR_MAX8973=m
        This has THERMAL_CONFIG=m

So there is no issue on making "depends on THERMAL".

Currently, only one user for this device in linux-next:
    arch/arm/boot/dts/r8a73a4-ape6evm.dts: compatible = "maxim,max8973";

and this is shmobile based.
    Adding Geert and Simon for their comment.