Re: [PATCH] pinctrl: lpc18xx: ensure ngroups is initialized at correct place

From: Linus Walleij
Date: Sun Mar 06 2016 - 22:29:20 EST


On Thu, Feb 25, 2016 at 12:32 AM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The initialization of ngroups is occurring at the end of the
> first iteration of the outer loop, which means that the
> assignment pins[ngroups++] = i is potentially indexing into
> a region outside of array pins because ngroups is not initialized.
> Instead, initialize ngroups in the inner loop before the first
> inner loop iteration.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Patch applied with Joachim's review tag.

Yours,
Linus Walleij