Re: [PATCHv9 1/3] rdmacg: Added rdma cgroup controller

From: Tejun Heo
Date: Sat Mar 05 2016 - 07:52:35 EST


Hello, Parav.

On Sat, Mar 05, 2016 at 04:45:09PM +0530, Parav Pandit wrote:
> Design that remains same from v6 to v10.
> * spin lock is still fine grained at cgroup level instead of one
> global shared lock among all cgroups.
> In future it can be optimized further to do per cpu or using
> single lock if required.
> * file type enums are still present for max and current, as
> read/write call to those files is already taken care by common
> functions with required if/else.
> * Resource limit setting is as it is, because number of devices are
> in range of 1 to 4 count in most use cases (as explained in
> documentation), and its not hot path.

1 and 2 are not okay. 3 is fine but resource [un]charging is not hot
path?

Thanks.

--
tejun