Re: [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device support

From: Suravee Suthikulpanit
Date: Sat Mar 05 2016 - 04:01:01 EST


Hi Joerg,

On 03/04/2016 03:49 PM, Wan, Vincent wrote:
Joerg,
Can you provide me which branch you are using to test those patches.

We are validating the patches in v4.5.0-rc6, and no issues like your
description.

I tested them on v4.5-rc5.

Thanks!
We will test the patches basing on this v4.5-rc5 version again.

Vincent.

Joerg


I found the issue now. I'll work with Vincent to send out V3.

The problem is because in the information in the IOMMU Attributes field of the IVHD header type 40h (offset byte 20 = struct ivhd_header.efr_attr) is incorrect. It was correct in the IVHD type 10h.... Sigh :(

However, the same information in the MMIO offset 4000h Counter configuration Register is correct. So, I'll try to have the patch get information from here instead.

Earlier, we had another issue with IOMMU PERF intialization, and it was disabled. So, it hides this bug when we were testing the patch earlier.
Now that we had a workaround for that bug n v4.5-rc5, it bombs in the init_iommu_perf_ctr().

So, if you want to test out the rest of this patch series, just simply comment out this function, and it should boot.

Regards,
Suravee