Re: [PATCH v11 17/24] perf config: Collect configs to handle config variables

From: Taeung Song
Date: Fri Mar 04 2016 - 21:55:30 EST




On 03/04/2016 10:58 PM, Namhyung Kim wrote:
Hi Taeung,

On Fri, Mar 04, 2016 at 09:45:44PM +0900, Taeung Song wrote:
Hi, Namhyung and all

(I'm modifying this patch to be tidy)
I have a mere question about name of a variable for
current config list that contains section list which has key-value
pairs from ~/.perfconfig or $(sysconfdir)/perfconfig config file.

(This variable is designed to be used by several functions
that handle config information(key-value pairs).)

I used 'sections' for this variable (type is 'struct list_head'),
but IMHO, I think that renaming it is better e.g.

1) 'cfglist'
2) 'configlist'
3) 'config_list'
4) 'cfgset'
5) 'configset'
6) 'config_set'
... :-\

It is trivial question,
but I wanna know a opinion of other people. :-)

I'd go with 3 or 6. Or simply 'configs' or 'perf_configs' is fine for
me.


Thank you for your opinion. :-)

Taeung