Re: [PATCH] null_blk: add lightnvm null_blk device to the nullb_list

From: Jens Axboe
Date: Fri Mar 04 2016 - 11:35:15 EST


On 03/04/2016 09:27 AM, Wenwei Tao wrote:
After register null_blk devices into lightnvm, we forget
to add these devices to the the nullb_list, makes them
invisible to the null_blk driver.

Signed-off-by: Wenwei Tao <ww.tao0320@xxxxxxxxx>
---
drivers/block/null_blk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c
index 64a7b59..cab9759 100644
--- a/drivers/block/null_blk.c
+++ b/drivers/block/null_blk.c
@@ -742,10 +742,11 @@ static int null_add_dev(void)

add_disk(disk);

+done:
mutex_lock(&lock);
list_add_tail(&nullb->list, &nullb_list);
mutex_unlock(&lock);
-done:
+
return 0;

out_cleanup_lightnvm:

Thanks, that looks like a regression caused by a514379b0c77, I'll add a Fixes tag.

--
Jens Axboe