Re: [PATCH v4 5/8] kbuild: add fine grained build dependencies for exported symbols

From: Michal Marek
Date: Thu Mar 03 2016 - 17:58:05 EST


Dne 29.2.2016 v 04:48 Nicolas Pitre napsal(a):
> +# Filter out exported kernel symbol names advertised as warning pragmas
> +# by the preprocessor and write them to $(1). We must consider continuation
> +# lines as well: they start with a blank, or the preceeding line ends with
> +# a ':'. Anything else is passed through as is.
> +# See also __KSYM_DEP() in include/linux/export.h.
> +ksym_dep_filter = sed -n \
> + -e '1 {x; $$!d}' \
> + -e '/^ / {H; $$!d}' \
> + -e 'x; /:$$/ {x; H; $$!d; s/^/ /; x}' \
> + -e ':filter; /^.*KBUILD_AUTOKSYM_DEP: /! {p; b next}' \
> + -e 's//KSYM_/; s/\n.*//; w $(1)' \
> + -e ':next; $$!d' \
> + -e '1 q; s/^/ /; x; /^ /! b filter'

This is unreadable and it does not work with my gcc version. I get
dependencies like

$(wildcard include/config/ksym/simple/strtoull [enabled by default].h) \

Please use some other way, which does not require parsing the compiler
diagnostic messages. A straightforward solution is to do something
similar to genksyms: A separate preprocessor pass with -Dsomething that
leaves the EXPORT_SYMBOL statements alone and just collect their occurences.

Thanks,
Michal