Re: [PATCH 1/5] usb: gadget: f_midi: refactor state machine

From: Clemens Ladisch
Date: Wed Mar 02 2016 - 16:15:13 EST


Felipe F. Tonello wrote:
> This refactor results in a cleaner state machine code

It increases the number of states, and now juggles two state variables.
I cannot agree to it being cleaner.

> and as a result fixed a bug when packaging a USB-MIDI packet right after
> a non-conformant MIDI byte stream.

I have been unable to determine where exactly the new code behaves
differently. Can you show an example?


Regards,
Clemens