Re: [PATCH v10 07/12] task_isolation: add debug boot flag

From: Peter Zijlstra
Date: Wed Mar 02 2016 - 15:37:59 EST


On Wed, Mar 02, 2016 at 03:09:31PM -0500, Chris Metcalf wrote:
> +void task_isolation_debug(int cpu)
> +{
> + struct task_struct *p;
> +
> + if (!task_isolation_possible(cpu))
> + return;
> +
> + rcu_read_lock();
> + p = cpu_curr(cpu);
> + get_task_struct(p);

As I think Oleg keeps reminding me, this is not actually a safe thing to
do.

> + rcu_read_unlock();
> + task_isolation_debug_task(cpu, p);
> + put_task_struct(p);
> +}