Re: [PATCH V14 8/9] vfio, platform: add support for ACPI while detecting the reset driver

From: Sinan Kaya
Date: Wed Mar 02 2016 - 13:34:46 EST


On 2/26/2016 12:15 PM, Eric Auger wrote:
>> -module_init(reset ## _module_init); \
>> > +#define module_vfio_reset_handler(compat, acpihid, reset) \
>> > +MODULE_ALIAS("vfio-reset:" compat); \
> Here you need to handle alias for hid case I think

I'm wondering what happens when Compat or ACPI string is NULL.

MODULE_ALIAS("vfio-reset:" NULL)

Would the kernel like it?

I'd rather create an alias only when the string is not NULL. Given
this is a macro, I believe it won't work.

Can you think of any other way in the code to create the alias?

--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project