Re: [RESEND PATCH v3 1/6] mfd: cros_ec: Add MKBP event support
From: One Thousand Gnomes
Date: Wed Mar 02 2016 - 07:34:41 EST
> +static int cros_ec_get_host_command_version_mask(struct cros_ec_device *ec_dev,
> + u16 cmd, u32 *mask)
> +{
> + struct ec_params_get_cmd_versions *pver;
> + struct ec_response_get_cmd_versions *rver;
> + struct cros_ec_command *msg;
> + int ret;
> +
> + msg = kmalloc(sizeof(*msg) + max(sizeof(*rver), sizeof(*pver)),
> + GFP_KERNEL);
> + if (!msg)
> + return -ENOMEM;
> +
> + msg->version = 0;
> + msg->command = EC_CMD_GET_CMD_VERSIONS;
> + msg->insize = sizeof(rver);
> + msg->outsize = sizeof(pver);
*rver and *pver surely ?