Re: [PATCH v2 block/for-linus] writeback: flush inode cgroup wb switches instead of pinning super_block

From: Jan Kara
Date: Wed Mar 02 2016 - 05:29:29 EST


On Tue 01-03-16 12:50:19, Tejun Heo wrote:
> Hello, Jens.
>
> On Tue, Mar 1, 2016 at 12:46 PM, Jens Axboe <axboe@xxxxxxxxx> wrote:
> > I queued this up for 4.5, but I'm feeling a bit uneasy about it. But it's
> > either that, or revert 5ff8eaac1636 and fix it for real in 4.6. Jan/Tejun,
> > what do you think?
>
> Given that this only matters for cgroup writeback cases, this should
> still be fairly low impact, so I don't think it'd matter too much
> whether we fix this in this cycle or for 4.6. However, that also means
> that we're not risking much by doing it in this cycle, so I'd vote for
> doing it now.

Yeah, without CGROUP_WRITEBACK enabled this patch is NOP so I don't care
much when this gets merged.

Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR