Re: [PATCH mmotm] mm, sl[au]b: print gfp_flags as strings in slab_out_of_memory()

From: David Rientjes
Date: Tue Mar 01 2016 - 17:41:49 EST


On Tue, 1 Mar 2016, Vlastimil Babka wrote:

> We can now print gfp_flags more human-readable. Make use of this in
> slab_out_of_memory() for SLUB and SLAB. Also convert the SLAB variant it to
> pr_warn() along the way.
>
> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>
> Cc: Christoph Lameter <cl@xxxxxxxxx>
> Cc: Pekka Enberg <penberg@xxxxxxxxxx>
> Cc: David Rientjes <rientjes@xxxxxxxxxx>
> Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

Although I've always been curious about the usefulness of these out of
memory calls in the first place. They are obviously for debugging, but
have they actually helped to diagnose anything?