Re: [RFC PATCH v1 2/2] powerpc/86xx: Introduce and use common dtsi

From: Scott Wood
Date: Tue Mar 01 2016 - 09:57:35 EST


On Tue, 2016-03-01 at 15:55 +0100, Alessio Igor Bogani wrote:
> Scott,
>
> On 29 February 2016 at 23:38, Scott Wood <oss@xxxxxxxxxxxx> wrote:
> [...]
> >
> > > +&pci0 {
> > > + compatible = "fsl,mpc8641-pcie";
> > > + device_type = "pci";
> > > + #size-cells = <2>;
> > > + #address-cells = <3>;
> > > + bus-range = <0x0 0xff>;
> > > + clock-frequency = <33333333>;
> >
> > The clock frequency of PCI Express is not 33 MHz.
>
> A lot of dtsi files into fsl directory have got that value!

Well, they shouldn't. :-P

This isn't the first time I've told someone to take that out.

-Scott