Re: [PATCH v5 06/15] scsi: ufs: separate device and host quirks

From: Hannes Reinecke
Date: Tue Mar 01 2016 - 02:38:27 EST


On 02/28/2016 09:32 PM, Yaniv Gardi wrote:
> Currently we use the host quirks mechanism in order to
> handle both device and host controller quirks.
> In order to support various of UFS devices we should separate
> handling the device quirks from the host controller's.
>
> Reviewed-by: Gilad Broner <gbroner@xxxxxxxxxxxxxx>
> Signed-off-by: Raviv Shvili <rshvili@xxxxxxxxxxxxxx>
> Signed-off-by: Yaniv Gardi <ygardi@xxxxxxxxxxxxxx>
>
> ---
> drivers/scsi/ufs/Makefile | 2 +-
> drivers/scsi/ufs/ufs.h | 31 +++++++++++
> drivers/scsi/ufs/ufs_quirks.c | 100 ++++++++++++++++++++++++++++++++++
> drivers/scsi/ufs/ufs_quirks.h | 124 ++++++++++++++++++++++++++++++++++++++++++
> drivers/scsi/ufs/ufshcd.c | 2 +
> drivers/scsi/ufs/ufshcd.h | 3 +
> 6 files changed, 261 insertions(+), 1 deletion(-)
> create mode 100644 drivers/scsi/ufs/ufs_quirks.c
> create mode 100644 drivers/scsi/ufs/ufs_quirks.h
>
Sigh. _Of course_ there will be device quirks.
Probably too much to hope to have a new implementation where everyone
agrees on the details.

Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)