Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on error path

[Andy Shevchenko]

On Fri, 2016-02-26 at 16:58 -0800, Stephen Boyd wrote:
> On 02/19, Andy Shevchenko wrote:
> > There is a potential resource leak in case when ->probe() fails. We
> > have to
> > unregister and remove clock tree which is done here.
> > 
> > This is a follow up to previously pushed commit c4726abce63b ("mfd:
> > intel_quark_i2c_gpio: Use clkdev_create()") that prevents double
> > free() when
> > clkdev_drop() followed by kfree() in devm_kcalloc() release stage.
> > 
> > I leave Fixes tag here, but the backporting will require to
> > backport the commit
> > c4726abce63b ("mfd: intel_quark_i2c_gpio: Use clkdev_create()")
> > first.
> > 
> > Fixes: 60ae5b9f5cdd (mfd: intel_quark_i2c_gpio: Add Intel Quark
> > X1000 I2C-GPIO MFD Driver)
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> 
> Both look fine to me.

Thanks for review!

>  You may also want to use
> devm_clk_register() instead so that cleanup is easier.

Perhaps in the future.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy