Re: [PATCH 1/2] sched/core: Get rid of 'cpu' argument in wq_worker_sleeping()

From: kbuild test robot
Date: Sun Feb 28 2016 - 12:48:57 EST


Hi Alexander,

[auto build test WARNING on wq/for-next]
[also build test WARNING on v4.5-rc6 next-20160226]
[cannot apply to tip/sched/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url: https://github.com/0day-ci/linux/commits/Alexander-Gordeev/sched-core-Cleanup-leftovers-in-__schedule/20160229-004522
base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-next
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

include/linux/init.h:1: warning: no structured comments found
>> kernel/workqueue.c:874: warning: Excess function parameter 'cpu' description in 'wq_worker_sleeping'
kernel/sys.c:1: warning: no structured comments found
drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found
drivers/dma-buf/reservation.c:1: warning: no structured comments found
include/linux/reservation.h:1: warning: no structured comments found
include/linux/spi/spi.h:540: warning: No description found for parameter 'max_transfer_size'

vim +874 kernel/workqueue.c

0fcb78c22f Rolf Eike Beer 2006-07-30 858 /**
e22bee782b Tejun Heo 2010-06-29 859 * wq_worker_sleeping - a worker is going to sleep
e22bee782b Tejun Heo 2010-06-29 860 * @task: task going to sleep
e22bee782b Tejun Heo 2010-06-29 861 * @cpu: CPU in question, must be the current CPU number
^1da177e4c Linus Torvalds 2005-04-16 862 *
e22bee782b Tejun Heo 2010-06-29 863 * This function is called during schedule() when a busy worker is
e22bee782b Tejun Heo 2010-06-29 864 * going to sleep. Worker on the same cpu can be woken up by
e22bee782b Tejun Heo 2010-06-29 865 * returning pointer to its task.
^1da177e4c Linus Torvalds 2005-04-16 866 *
e22bee782b Tejun Heo 2010-06-29 867 * CONTEXT:
e22bee782b Tejun Heo 2010-06-29 868 * spin_lock_irq(rq->lock)
^1da177e4c Linus Torvalds 2005-04-16 869 *
d185af300f Yacine Belkadi 2013-07-31 870 * Return:
e22bee782b Tejun Heo 2010-06-29 871 * Worker task on @cpu to wake up, %NULL if none.
^1da177e4c Linus Torvalds 2005-04-16 872 */
479b9d020d Alexander Gordeev 2016-02-28 873 struct task_struct *wq_worker_sleeping(struct task_struct *task)
^1da177e4c Linus Torvalds 2005-04-16 @874 {
e22bee782b Tejun Heo 2010-06-29 875 struct worker *worker = kthread_data(task), *to_wakeup = NULL;
111c225a5f Tejun Heo 2013-01-17 876 struct worker_pool *pool;
f293ea9200 Oleg Nesterov 2007-05-09 877
111c225a5f Tejun Heo 2013-01-17 878 /*
111c225a5f Tejun Heo 2013-01-17 879 * Rescuers, which may not have all the fields set up like normal
111c225a5f Tejun Heo 2013-01-17 880 * workers, also reach here, let's not access anything before
111c225a5f Tejun Heo 2013-01-17 881 * checking NOT_RUNNING.
111c225a5f Tejun Heo 2013-01-17 882 */

:::::: The code at line 874 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data