Re: Question about prio_changed_dl()

From: luca abeni
Date: Sat Feb 27 2016 - 06:38:38 EST


On Thu, 25 Feb 2016 15:52:02 +0100
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Thu, Feb 25, 2016 at 03:25:58PM +0100, luca abeni wrote:
>
> > > > (BTW, it seems to me that switched_to_dl() is never invoked, for
> > > > some reason...)
> > >
> > > Hmm, it should be invoked if you do sched_setattr() to get
> > > SCHED_DEADLINE.
> >
> > Sorry, that was me being confused...
> > It is prio_changed_dl() that is not invoked when the deadline
> > parameters are changed (I am testing a change to fix this - it actually
> > is included in the "Move the remaining __dl_{sub,add}_ac() calls from
> > core.c to deadline.c" patch I posted on Monday; I am going to extract
> > it in a separate patch).
>
> Ah ok. So the idea was that the || dl_task() part would ensure
> ->prio_changed() would always be called.
>
> I'll await your patch.