Re: [PATCH 3/6] perf, tools, stat: Support metrics in --per-core/socket mode

From: Andi Kleen
Date: Fri Feb 26 2016 - 18:53:40 EST


> > +
> > static void print_aggr(char *prefix)
> > {
> > FILE *output = stat_config.output;
> > @@ -982,6 +1024,8 @@ static void print_aggr(char *prefix)
> > if (!(aggr_map || aggr_get_id))
> > return;
> >
> > + aggr_update_shadow();
>
> this should be called from perf_stat_process_counter,
> not from display function

I tried it, but the function needs a lot of stuff (aggr_map,
evsel_list) that only exists in builtin-stat. Passing all
that around is quite complicated and intrusive.

I left it alone for now.

-Andi