Re: [PATCH v1 0/3] PCI: Avoid touching non-compliant BARs

From: Andi Kleen
Date: Fri Feb 26 2016 - 11:55:58 EST


On Fri, Feb 26, 2016 at 09:58:42AM -0600, Bjorn Helgaas wrote:
> Hi guys,
>
> Here's a proposal for dealing with these devices that have non-BAR
> registers where BARs are supposed to be. The idea is to:
>
> - have an early quirk mark these devices,
> - disable IO & MEM decoding so the devices don't consume address space
> we don't know about, and
> - skip BAR sizing (so the struct resources stay zeroed out)
>
> This is basically a modification of what Andi originally proposed. The
> difference here is that we never touch the BAR at all, and we don't have to
> add any struct resource flags, so we don't have to worry about changing any
> consumers of the struct resources.
>
> Let me know what you think.

I tested the patch on Broadwell and it avoids the Firmware Bug messages.

Tested-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

-Andi