Re: [PATCH 2/2] crypto: remove padding logic from rsa.c

From: David Howells
Date: Fri Feb 26 2016 - 09:00:29 EST


Tadeusz Struk <tadeusz.struk@xxxxxxxxx> wrote:

> + if (memcmp(sig->digest, output, sig->digest_size) ||

I've added " != 0" after the memcmp().

> + req->dst_len != sig->digest_size)
> + ret = -EBADMSG;

Btw, this has to be -EKEYREJECTED; -EBADMSG would indicate that the container
is unparseable. I wonder if we should propose a -ESIGREJECTED error...

David