Re: [PATCH v3 2/2] rtc: rtc-pic32: Add PIC32 real time clock driver

From: Alexandre Belloni
Date: Thu Feb 25 2016 - 13:20:46 EST


On 25/02/2016 at 10:30:44 -0700, Joshua Henderson wrote :
> This driver adds support for the PIC32 real time clock and calendar
> peripheral:
> - reading and setting time
> - alarms provided by dedicated IRQ
>
> Signed-off-by: Joshua Henderson <joshua.henderson@xxxxxxxxxxxxx>
> ---
> Changes since v2:
> - Fix rework bug causing unecessary retries for gettime.
> - Word commit message to be more precise.
> Changes since v1:
> - Fix checkpatch.pl --strict issues.
> - Fix alpabetical makefile ordering.
> - Specify consistent license.
> - General formatting cleanup.
> - Drop unecessary flags_lock.
> - Replace ugly gogo with do while.
> - Remove unecessary checks on time when setting alarm.
> - Don't initialize the RTC in probe.
> ---
> drivers/rtc/Kconfig | 10 ++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-pic32.c | 411 +++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 422 insertions(+)
> create mode 100644 drivers/rtc/rtc-pic32.c
>
Applied, thanks.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com