Re: [PATCH 2/2] hvc_xen: fix xenboot for DomUs

From: Stefano Stabellini
Date: Wed Feb 24 2016 - 10:48:42 EST


Hi kbuild test robot,

you are awesome as always. I'll fix it in the next version.

Thanks,

Stefano

On Wed, 24 Feb 2016, kbuild test robot wrote:
> Hi Stefano,
>
> [auto build test WARNING on tty/tty-testing]
> [also build test WARNING on v4.5-rc5 next-20160223]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url: https://github.com/0day-ci/linux/commits/Stefano-Stabellini/hvc_xen-add-earlycon-support/20160224-203006
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> config: x86_64-randconfig-x009-201608 (attached as .config)
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All warnings (new ones prefixed by >>):
>
> drivers/tty/hvc/hvc_xen.c: In function 'xenboot_setup_console':
> >> drivers/tty/hvc/hvc_xen.c:637:1: warning: control reaches end of non-void function [-Wreturn-type]
> }
> ^
>
> vim +637 drivers/tty/hvc/hvc_xen.c
>
> 621 }
> 622 if (off < len)
> 623 domU_write_console(0, string+off, len-off);
> 624 }
> 625
> 626 #ifdef CONFIG_EARLY_PRINTK
> 627 static int xenboot_setup_console(struct console *console, char *string)
> 628 {
> 629 static struct xencons_info xenboot;
> 630
> 631 if (xen_initial_domain())
> 632 return 0;
> 633 if (!xen_pv_domain())
> 634 return -ENODEV;
> 635
> 636 xen_early_pv_console_init(&xenboot, 0);
> > 637 }
> 638
> 639 static void xenboot_write_console(struct console *console, const char *string,
> 640 unsigned len)
> 641 {
> 642 if (!xen_pv_domain())
> 643 return;
> 644
> 645 dom0_write_console(0, string, len);
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>