Re: [PATCH v4 00/11] KVM: x86: track guest page access

From: Paolo Bonzini
Date: Wed Feb 24 2016 - 08:42:17 EST




On 24/02/2016 10:51, Xiao Guangrong wrote:
> Changelog in v4:
> thanks to Paolo's review, the changes in this version are:
> - comment struct kvm_mmu_page_role to explain the rule bits used by indirect
> shadow page can not be more than 15 bits
> - simplify overflow detection of track count
> - remove the wrap functions, kvm_page_track_{add,remove}_page
> - rename kvm_slot_page_track_*_nolock to kvm_slot_page_track_*
> - rename the function, check_mode, to page_track_mode_is_valid and inline it
> - rename kvm_page_track_check_mode to kvm_page_track_is_active
> - check if the notifier list is empty before holding the srcu lock
> - move the patch adjusting write-flooding more earlier

Looks good, thanks!

Paolo