Re: [PATCH v8 4/8] time: Add driver cross timestamp interface for higher precision time synchronization

From: Thomas Gleixner
Date: Wed Feb 24 2016 - 05:56:04 EST


On Mon, 22 Feb 2016, Christopher S. Hall wrote:
> +int get_device_system_crosststamp(int (*get_time_fn)
> + (ktime_t *device_time,
> + struct system_counterval_t *sys_counterval,
> + void *ctx),
> + void *ctx,
> + struct system_device_crosststamp *xtstamp)
> +{
> + struct timekeeper *tk = &tk_core.timekeeper;
> + unsigned long seq;
> + struct system_counterval_t system_counterval;
> + ktime_t base_raw;
> + ktime_t base_real;
> + s64 nsec_raw;
> + s64 nsec_real;

Single lines for same and desceding length ordered, which makes it simpler to
parse, please.

Other than that: Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>