Re: [PATCH v5] serial: 8250: add gpio support to exar

From: Greg Kroah-Hartman
Date: Sun Feb 07 2016 - 16:35:33 EST


On Sun, Feb 07, 2016 at 07:24:15PM +0530, Sudip Mukherjee wrote:
> On Sunday 07 February 2016 12:14 PM, Greg Kroah-Hartman wrote:
> >On Tue, Jan 19, 2016 at 11:36:35AM +0530, Sudip Mukherjee wrote:
> >>Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which
> >>can be controlled using gpio interface.
> >>Add support to use these pins.
> >>
> >>Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> >>---
> >
> >I need an ack from the gpio maintainer before I can take this.
> >
> >Or was it going to be reworked again?
>
> I have not yet started with the rework, but Andy wants me to split out the
> exar related code from 8250_pci and create its own driver. But at the
> initial discussion you were against having a separate driver for it.
> what will you suggest?

I don't remember what my initial suggestion was at all, sorry. But I
like what Peter was doing with the other tty driver splitout, so that
might be the correct thing to do here.

thanks,

greg k-h