Re: [PATCH 3/3 v5] cpufreq: governor: Replace timers with utilization update callbacks

From: Viresh Kumar
Date: Sun Feb 07 2016 - 10:36:49 EST


On 07-02-16, 15:50, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Instead of using a per-CPU deferrable timer for queuing up governor
> work items, register a utilization update callback that will be
> invoked from the scheduler on utilization changes.
>
> The sampling rate is still the same as what was used for the
> deferrable timers and the added irq_work overhead should be offset by
> the eliminated timers overhead, so in theory the functional impact of
> this patch should not be significant.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---
>
> Changes from v4:
> - Moved init_irq_work() to alloc_common_dbs_info() so it is done along with
> the INIT_WORK() on the main work structure (which seems more logical to me).
> - Added the ACK from Viresh (in the hope that it still applied).

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh