Re: [PATCH V2] tty/n_gsm.c: use gsm->num to remove mux itself from gsm_mux[]

[Pan Xinhui]

hi, Greg
	thanks for your reply.
On 2016/2/7 15:29, Greg Kroah-Hartman wrote:
> On Tue, Jan 05, 2016 at 03:42:52PM +0800, Pan Xinhui wrote:
> > From: Pan Xinhui <xinhui.pan@xxxxxxxxxxxxxxxxxx>
> >
> > There is one filed gsm->num to store mux's index of gsm_mux[]. So use
> > gsm->num to remove itself from gsm_mux[] instead of the for-loop
> > traverse in gsm_cleanup_mux().
> >
> > Signed-off-by: Pan Xinhui <xinhui.pan@xxxxxxxxxxxxxxxxxx>
> > Reviewed-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
> > ---
> > change from V1:
> > 	lock is also held for the if()
> > ---
> >   drivers/tty/n_gsm.c | 13 +++++--------
> >   1 file changed, 5 insertions(+), 8 deletions(-)
>
> Doesn't apply to my tty-next branch of the tty.git tree :(

Sorry for not telling you one important information.
This patch is on top of Jiri's patch, "TTY: n_gsm, fix false positive WARN_ON", see https://patchwork.kernel.org/patch/7692181/
Looks like Jiri's patch is still not in your tree.

Hi, Jiri
	Could I make a new patch on top of the mainline's codes first then you prepare your patch on top of mine?
I will appreciate that if you have a better solution :)


thanks
xinhui