complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional

From: James Bottomley
Date: Sat Feb 06 2016 - 13:34:19 EST


The reason is fairly obvious: the default for the new option
BLK_DEV_NVME_SCSI is N and all the distribution kernels (and me when
testing) take the default options (I checked in the OBS kernel builds
and this is true).

The net result is that scsi_id from udev no longer works on nvme disks
and that means that the /dev/disk/by-id links are all gone in 4.5-rc1.
If this happens to be how you name your disks in fstab or crypttab,
you can't boot.

If you're going to break an ABI in this way, you really have to plan
for it in userspace. How are NVMe disk ids supposed to be exported
now? Does udev need a nvme_id program to do this? Until there's an
infrastructure ready to work in this way, we need to unconditionally
enable BLK_DEV_NVME_SCSI.

James