Re: [PATCH] Staging:iio:Remove exceptional & on function name

From: Jonathan Cameron
Date: Sat Feb 06 2016 - 13:19:15 EST


On 05/02/16 03:53, Bhumika Goyal wrote:
> In this file,function names are otherwise used as pointers without &.
> Found using coccinelle.
> // <smpl>
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> // </smpl>
>
> Signed-off-by: Bhumika Goyal <bhumirks@xxxxxxxxx>
Nice little bit of tidying up.

Applied to the togreg branch of iio.git - initially pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
> ---
> drivers/staging/iio/impedance-analyzer/ad5933.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index 10c43dda..d1218d8 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -558,7 +558,7 @@ out:
> }
>
> static const struct iio_info ad5933_info = {
> - .read_raw = &ad5933_read_raw,
> + .read_raw = ad5933_read_raw,
> .attrs = &ad5933_attribute_group,
> .driver_module = THIS_MODULE,
> };
> @@ -616,9 +616,9 @@ static int ad5933_ring_postdisable(struct iio_dev *indio_dev)
> }
>
> static const struct iio_buffer_setup_ops ad5933_ring_setup_ops = {
> - .preenable = &ad5933_ring_preenable,
> - .postenable = &ad5933_ring_postenable,
> - .postdisable = &ad5933_ring_postdisable,
> + .preenable = ad5933_ring_preenable,
> + .postenable = ad5933_ring_postenable,
> + .postdisable = ad5933_ring_postdisable,
> };
>
> static int ad5933_register_ring_funcs_and_init(struct iio_dev *indio_dev)
>