Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

From: Daniel Baluta
Date: Fri Feb 05 2016 - 16:44:54 EST


On Fri, Feb 5, 2016 at 11:02 PM, Lucas De Marchi
<lucas.de.marchi@xxxxxxxxx> wrote:
> Hi Daniel,
>
> On Fri, Feb 5, 2016 at 11:17 AM, Daniel Baluta <daniel.baluta@xxxxxxxxx> wrote:
>> +
>> +static const struct i2c_device_id ads1015_id[] = {
>> + {"ads1015", 0},
>> + {}
>> +};
>
> Since this module is not 100% compatible with the hwmon version,
> wouldn't it be better to use another id?

Hmm, as it is now it should be 100% compatible with the hwmon driver
for ads1015 device.

I don't have a strong preference for id here. Do you see any problems using
this id?

>
> Other than that, I tested it on the MinnowBoard Max with a Drone Lure
> connected and it works fine.

thanks,
Daniel.