Re: [PATCH] block-dev: enable writeback cgroup support

From: Shaohua Li
Date: Fri Feb 05 2016 - 12:44:54 EST


On Fri, Feb 05, 2016 at 12:21:39PM -0500, Tejun Heo wrote:
> On Mon, Feb 01, 2016 at 05:50:33PM -0800, Shaohua Li wrote:
> > block_dev's .writepages/.writepage already handles
> > wbc_init_bio/wbc_account_io. We only set the SB_I_CGROUPWB bit to
> > suppport writeback cgroup support.
> >
> > Signed-off-by: Shaohua Li <shli@xxxxxx>
>
> Acked-by: Tejun Heo <tj@xxxxxxxxxx>
>
> Can you please describe a bit how you tested it tho?

I'm doing a simple buffered write to a disk, assign it to a cgroup and
blk-throttle sets wbps for the disk/cgroup. then I'm watching iostat
with/without the bit set.

Thanks,
Shaohua